Skip to content

Potential fix for code scanning alert no. 146: Unbounded write #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

Potential fix for code scanning alert no. 146: Unbounded write #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions async-toolkit/atools/lib/archive.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,13 @@
entry->uses=1;

entry->archive=leak_realloc(entry->archive,strlen(archive)+1);
strcpy(entry->archive,archive);
strncpy(entry->archive,archive,strlen(archive)+1);

Check failure

Code scanning / CodeQL

Possibly wrong buffer size in string copy Critical

Potentially unsafe call to strncpy; third argument should be size of destination.

entry->member=leak_realloc(entry->member,strlen(member)+1);
strcpy(entry->member,member);
strncpy(entry->member,member,strlen(member)+1);

Check failure

Code scanning / CodeQL

Possibly wrong buffer size in string copy Critical

Potentially unsafe call to strncpy; third argument should be size of destination.

entry->output=leak_realloc(entry->output,strlen(output)+1);
strcpy(entry->output,output);
strncpy(entry->output,output,strlen(output)+1);

Check failure

Code scanning / CodeQL

Possibly wrong buffer size in string copy Critical

Potentially unsafe call to strncpy; third argument should be size of destination.
}

int archive_extract(char *archive, char *member, char *output)
Expand Down
Loading