-
Notifications
You must be signed in to change notification settings - Fork 22
Add numba-mlir benchs #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@diptorupd I had an issue with dpctl tensor pickling when passing them into child process, so I had to move allocation into child process. See this FYI |
1b39e7c to
df6f70d
Compare
|
@diptorupd it is ready for review |
adarshyoga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment - How do you plan to run numba-milr workloads in dpbench CI?
d43a70c to
811408d
Compare
|
@diptorupd ping |
|
@Hardcode84 With all the recent infrastructure changes for dpbench, it is now possible to have benchmarks and frameworks out of tree and easily run them using dpbench infrastructure. I think it will be better to have these dpbench benchmark implementations in numba-mlir and set up a CI where the implementations can be tested. What do you think? |
They still need infra changes as framework selection logic is still hardcoded. And having them in main repo is plan we all agreed upon, and eventually they should be run as part of general perf evaluation together with dpnp and dpex. |
40d3088 to
8b051fc
Compare
|
@Hardcode84 Please add a PR description and update the PR to latest main. We can then do a last review and merge. |
|
Also, can you clean up the commits? Lots of "fix", "wip" commits currently. |
Just squash all of them during merge, no point to clean up |
In that case, please squash and force push. Squash and merge is disabled on the repo. Main issue though is to update the PR to current main. |
8b051fc to
edac78b
Compare
2aef4ee to
9176405
Compare
a06ffe9 to
f2c5982
Compare
|
Thank you for the PR @Hardcode84 ! It looks great! Just one last change about flake8 and we are good to go. |
|
@adarshyoga do you have any other comments? If no, please remove your change request. |
Add
numba-mlirbased benchmarks with related framework and config changes.