Skip to content

Conversation

@Hardcode84
Copy link
Contributor

@Hardcode84 Hardcode84 commented Nov 21, 2022

Add numba-mlir based benchmarks with related framework and config changes.

  • blackscholes
  • l2_norm
  • pairwise_distance

@Hardcode84
Copy link
Contributor Author

@diptorupd I had an issue with dpctl tensor pickling when passing them into child process, so I had to move allocation into child process. See this _setup -> _setup_func change.

FYI

@Hardcode84 Hardcode84 force-pushed the dpcomp-bench branch 4 times, most recently from 1b39e7c to df6f70d Compare April 12, 2023 20:26
@Hardcode84 Hardcode84 changed the title [WIP] Add dpcomp benchs Add dpcomp benchs Apr 12, 2023
@Hardcode84 Hardcode84 changed the title Add dpcomp benchs Add numba-mlir benchs Apr 12, 2023
@Hardcode84 Hardcode84 marked this pull request as ready for review April 12, 2023 20:57
@Hardcode84
Copy link
Contributor Author

@diptorupd it is ready for review

Copy link
Contributor

@adarshyoga adarshyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment - How do you plan to run numba-milr workloads in dpbench CI?

@Hardcode84 Hardcode84 force-pushed the dpcomp-bench branch 2 times, most recently from d43a70c to 811408d Compare April 18, 2023 22:26
@Hardcode84
Copy link
Contributor Author

@diptorupd ping

@diptorupd
Copy link

@Hardcode84 With all the recent infrastructure changes for dpbench, it is now possible to have benchmarks and frameworks out of tree and easily run them using dpbench infrastructure.

I think it will be better to have these dpbench benchmark implementations in numba-mlir and set up a CI where the implementations can be tested. What do you think?

@Hardcode84
Copy link
Contributor Author

@Hardcode84 With all the recent infrastructure changes for dpbench, it is now possible to have benchmarks and frameworks out of tree and easily run them using dpbench infrastructure.

They still need infra changes as framework selection logic is still hardcoded. And having them in main repo is plan we all agreed upon, and eventually they should be run as part of general perf evaluation together with dpnp and dpex.

@Hardcode84 Hardcode84 force-pushed the dpcomp-bench branch 2 times, most recently from 40d3088 to 8b051fc Compare April 27, 2023 13:13
@diptorupd
Copy link

@Hardcode84 Please add a PR description and update the PR to latest main. We can then do a last review and merge.

@diptorupd
Copy link

Also, can you clean up the commits? Lots of "fix", "wip" commits currently.

@Hardcode84
Copy link
Contributor Author

Also, can you clean up the commits? Lots of "fix", "wip" commits currently.

Just squash all of them during merge, no point to clean up

@diptorupd
Copy link

Also, can you clean up the commits? Lots of "fix", "wip" commits currently.

Just squash all of them during merge, no point to clean up

In that case, please squash and force push. Squash and merge is disabled on the repo.

Main issue though is to update the PR to current main.

@Hardcode84 Hardcode84 force-pushed the dpcomp-bench branch 2 times, most recently from 2aef4ee to 9176405 Compare April 27, 2023 20:32
@Hardcode84 Hardcode84 force-pushed the dpcomp-bench branch 2 times, most recently from a06ffe9 to f2c5982 Compare April 29, 2023 14:31
@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented May 1, 2023

Thank you for the PR @Hardcode84 ! It looks great! Just one last change about flake8 and we are good to go.

@Hardcode84
Copy link
Contributor Author

@adarshyoga do you have any other comments? If no, please remove your change request.

@ZzEeKkAa ZzEeKkAa requested a review from adarshyoga May 1, 2023 20:18
@ZzEeKkAa ZzEeKkAa enabled auto-merge May 1, 2023 20:20
@ZzEeKkAa ZzEeKkAa dismissed adarshyoga’s stale review May 1, 2023 20:45

All changes applied

@ZzEeKkAa ZzEeKkAa merged commit 5300f94 into IntelPython:main May 1, 2023
@Hardcode84 Hardcode84 deleted the dpcomp-bench branch May 1, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants