Skip to content

Make sycl optional #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZzEeKkAa merged 1 commit into from
May 23, 2023
Merged

Make sycl optional #268

ZzEeKkAa merged 1 commit into from
May 23, 2023

Conversation

@ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented May 19, 2023 •
edited
Loading

Move conda requirements to files. Make sycl optional, switch to pyproject over setup.py, update README.md.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this May 19, 2023
@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_sycl_optional branch 5 times, most recently from 2bde17d to e74e64e Compare May 22, 2023 13:59
@ZzEeKkAa ZzEeKkAa changed the title WIP: Make sycl optional Make sycl optional May 22, 2023
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review May 22, 2023 14:00
@ZzEeKkAa ZzEeKkAa enabled auto-merge May 22, 2023 14:00
@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_sycl_optional branch from e74e64e to ccdff85 Compare May 22, 2023 14:01
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd May 22, 2023 14:36
@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_sycl_optional branch from ccdff85 to 41181a3 Compare May 22, 2023 18:51
diptorupd
diptorupd reviewed May 22, 2023
View reviewed changes
diptorupd
diptorupd reviewed May 22, 2023
View reviewed changes
@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_sycl_optional branch from 41181a3 to 93e0a40 Compare May 22, 2023 22:10
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd May 23, 2023 00:44
@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_sycl_optional branch from 93e0a40 to 9b8fad1 Compare May 23, 2023 17:05
diptorupd
diptorupd reviewed May 23, 2023
View reviewed changes
diptorupd
diptorupd reviewed May 23, 2023
View reviewed changes
diptorupd
diptorupd reviewed May 23, 2023
View reviewed changes
@diptorupd diptorupd disabled auto-merge May 23, 2023 20:44
diptorupd
diptorupd approved these changes May 23, 2023
View reviewed changes
Copy link

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor README changes!

@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_sycl_optional branch from 9b8fad1 to 66d7a77 Compare May 23, 2023 21:04
@ZzEeKkAa ZzEeKkAa enabled auto-merge May 23, 2023 21:05
@ZzEeKkAa ZzEeKkAa merged commit ac2c357 into main May 23, 2023
@ZzEeKkAa ZzEeKkAa deleted the feature/make_sycl_optional branch May 23, 2023 21:19
@ZzEeKkAa ZzEeKkAa mentioned this pull request Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@diptorupd diptorupd diptorupd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ZzEeKkAa ZzEeKkAa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZzEeKkAa @diptorupd