Skip to content

Update kmeans #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
diptorupd merged 1 commit into from
Jun 27, 2023
Merged

Update kmeans #278

diptorupd merged 1 commit into from
Jun 27, 2023

Conversation

@AlexanderKalistratov
Copy link
Collaborator

@AlexanderKalistratov AlexanderKalistratov commented Jun 14, 2023 •
edited
Loading

  • Replace sycl, numba_dpex_k and numba_mlir_k implementations with optimized one.
  • Move initial centroids picking to intialization step. There are different algorithms for this step. It is should be implemented and optimized separately.
  • Move temporal buffers allocations from initialization step to implementation itself as this part is different for different implementations and should be measured.
  • Remove duplicated parameters returned from initialization step.

@AlexanderKalistratov
Copy link
Collaborator Author

AlexanderKalistratov commented Jun 15, 2023

Blocker issue: IntelPython/numba-dpex#1068

@AlexanderKalistratov AlexanderKalistratov force-pushed the kmeans branch 2 times, most recently from 6cdda85 to 8446992 Compare June 26, 2023 00:10
@AlexanderKalistratov AlexanderKalistratov marked this pull request as ready for review June 26, 2023 22:53
@AlexanderKalistratov
Copy link
Collaborator Author

AlexanderKalistratov commented Jun 26, 2023

Add numba_dpex_k implementation to expected failure list

Hardcode84
Hardcode84 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@Hardcode84 Hardcode84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@diptorupd please take a look

@AlexanderKalistratov
Copy link
Collaborator Author

AlexanderKalistratov commented Jun 26, 2023

@ZzEeKkAa @diptorupd I don't have rights even to ask for review.

@diptorupd diptorupd merged commit 432d276 into IntelPython:main Jun 27, 2023
@diptorupd
Copy link

diptorupd commented Jun 27, 2023

@ZzEeKkAa @diptorupd I don't have rights even to ask for review.

I have added you to the project.

@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Jun 27, 2023 •
edited
Loading

LGTM

@AlexanderKalistratov why does numba_dpex_k fails now?

@AlexanderKalistratov
Copy link
Collaborator Author

AlexanderKalistratov commented Jun 27, 2023

LGTM

@AlexanderKalistratov why does numba_dpex_k fails now?

numba-dpex regression IntelPython/numba-dpex#1068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

1 more reviewer

@Hardcode84 Hardcode84 Hardcode84 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexanderKalistratov @diptorupd @ZzEeKkAa @Hardcode84