Skip to content

Added dtype parameter in np.cov() function call. #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZzEeKkAa merged 1 commit into from
Jun 20, 2023
Merged

Added dtype parameter in np.cov() function call. #280

ZzEeKkAa merged 1 commit into from
Jun 20, 2023

Conversation

@npolina4
Copy link
Contributor

@npolina4 npolina4 commented Jun 20, 2023

Function np.cov() returns double-precision floating-point dtype by default.
Added dtype parameter in np.cov() function call to avoid upcast of results dtype for single-precision floating-point input.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@npolina4 npolina4 requested review from ZzEeKkAa and diptorupd June 20, 2023 20:17
ZzEeKkAa
ZzEeKkAa approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZzEeKkAa ZzEeKkAa merged commit b851eec into main Jun 20, 2023
@ZzEeKkAa ZzEeKkAa deleted the dpnp_cov_dtype branch June 20, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

1 more reviewer

@ZzEeKkAa ZzEeKkAa ZzEeKkAa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@npolina4 @ZzEeKkAa