Skip to content

Resolve a typo in exceptions docstrings #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

Resolve a typo in exceptions docstrings #2169

merged 2 commits into from
Oct 13, 2025

Conversation

@antonwolfy
Copy link
Collaborator

@antonwolfy antonwolfy commented Oct 10, 2025 •
edited
Loading

This PR updates text in SyclContextCreationError and SyclDeviceCreationError exception to fix a typo there.
Also minor typos in a test and example were resolved.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@antonwolfy antonwolfy self-assigned this Oct 10, 2025
vlad-perevezentsev
vlad-perevezentsev approved these changes Oct 10, 2025
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@github-actions
Copy link

github-actions bot commented Oct 10, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_24 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Oct 10, 2025

Coverage Status

coverage: 85.264%. remained the same
when pulling 516acaa on fix-typo-in-exceptions-docstrings
into 3dfc117 on master.

@ndgrigorian ndgrigorian merged commit 2d80765 into master Oct 13, 2025
69 of 80 checks passed
@ndgrigorian ndgrigorian deleted the fix-typo-in-exceptions-docstrings branch October 13, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antonwolfy @coveralls @ndgrigorian @vlad-perevezentsev