Skip to content

Fix formatting of errors in _sycl queue.pyx#2290

Merged
ndgrigorian merged 2 commits intomasterfrom
fix-errors-formatting-sycl-queue
Apr 23, 2026
Merged

Fix formatting of errors in _sycl queue.pyx#2290
ndgrigorian merged 2 commits intomasterfrom
fix-errors-formatting-sycl-queue

Conversation

@ndgrigorian
Copy link
Copy Markdown
Collaborator

This PR changes formatting of various errors in _sycl_queue.pyx, in some cases correcting missing f strings, in others just for organization

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

RawKernelArg and WorkGroupMemory error messages were incorrectly formatted
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 77.262% (-0.08%) from 77.341% — fix-errors-formatting-sycl-queue into master

Copy link
Copy Markdown
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndgrigorian ndgrigorian merged commit 39b31e6 into master Apr 23, 2026
73 of 74 checks passed
@ndgrigorian ndgrigorian deleted the fix-errors-formatting-sycl-queue branch April 23, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants