Skip to content

Remove work-around in dpctl.SyclPlatform.get_devices for custom and automatic device types#2303

Merged
ndgrigorian merged 1 commit intomasterfrom
remove-platform-get-devices-work-around
Apr 28, 2026
Merged

Remove work-around in dpctl.SyclPlatform.get_devices for custom and automatic device types#2303
ndgrigorian merged 1 commit intomasterfrom
remove-platform-get-devices-work-around

Conversation

@ndgrigorian
Copy link
Copy Markdown
Collaborator

This PR removes a work-around added to dpctl.SyclPlatform.get_devices due to a bug in the implementation, where the device types "automatic" and "custom" would return "all"

To work-around, these were treated as "unknown" and returned an empty list instead of a full list

The work-around is no longer necessary

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 75.476%. remained the same — remove-platform-get-devices-work-around into master

Copy link
Copy Markdown
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @ndgrigorian

@ndgrigorian ndgrigorian merged commit 86d7384 into master Apr 28, 2026
69 of 74 checks passed
@ndgrigorian ndgrigorian deleted the remove-platform-get-devices-work-around branch April 28, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants