Device descriptor image2d3d functions #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
1e-to
requested review from
diptorupd and
oleksandr-pavlyk
and removed request for
diptorupd
58 tasks
diptorupd
reviewed
Mar 31, 2021
| DPCTLSyclDeviceRef DRef = nullptr; | ||
| size_t image_2d_max_width = 0; | ||
| EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef)); | ||
| if (!DRef) |
Contributor
There was a problem hiding this comment.
I changed the test cases in master. I moved the DPCTLDevice_CreateFromSelector into the fixture constructor and the GTEST_SKIP to the SetUp(). Reduces the redundant code in each test case. Please update these test cases in the same way.
| return hasAspect; | ||
| } | ||
|
|
||
| #define declmethod(FUNC, NAME) \ |
added 2 commits
April 7, 2021 08:20
oleksandr-pavlyk
approved these changes
Apr 7, 2021
Contributor
oleksandr-pavlyk
left a comment
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
Need to be squashed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
info::device::image2d_max_width (size_t)
info::device::image2d_max_height (size_t)
info::device::image3d_max_width (size_t)
info::device::image3d_max_height (size_t)
info::device::image3d_max_depth (size_t)