Fixes names #378
Merged
Fixes names #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptorupd
reviewed
Apr 8, 2021
| DPCTL_API | ||
| DPCTLSyclBackendType | ||
| DPCTLDevice_GetBackend(__dpctl_keep const DPCTLSyclDeviceRef DRef); | ||
| DPCTLDevice_GetBackendVersion(__dpctl_keep const DPCTLSyclDeviceRef DRef); |
Contributor
There was a problem hiding this comment.
This function does not need renaming. The SYCL function is called get_backend too.
Contributor
There was a problem hiding this comment.
@1e-to can make this change? I will like to have this change in 0.7.0.
Contributor
There was a problem hiding this comment.
Oops missed your change. All set.
oleksandr-pavlyk
suggested changes
Apr 9, 2021
Contributor
oleksandr-pavlyk
left a comment
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
@1e-to Please revert the change to DPCTLDevice_GetBackend -> DPCTLDevice_GetBackendVersion per @diptorupd comment.
added 2 commits
April 12, 2021 08:49
examples/cython/sycl_buffer/bench.py
Outdated
| print( | ||
| "SYCL({}) result: {}".format( | ||
| dpctl.get_current_queue().get_sycl_device().get_device_name(), | ||
| dpctl.get_current_queue().get_sycl_device().name, |
Contributor
There was a problem hiding this comment.
Perhaps it should be dpctl.get_current_queue().sycl_device.name to simplify?
oleksandr-pavlyk
previously approved these changes
Apr 12, 2021
Contributor
oleksandr-pavlyk
left a comment
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
This is looking good. Thank you @1e-to
oleksandr-pavlyk
approved these changes
Apr 13, 2021
diptorupd
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #284