Refactor dpnp.fix() to reuse dpnp.trunc internally
#2722
+54
−330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-perevezentsev
requested review from
antonwolfy and
ndgrigorian
as code owners
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2722/index.html |
antonwolfy
reviewed
Jan 15, 2026
| assert_array_equal(result, expected) | ||
|
|
||
| @pytest.mark.parametrize("xp", [numpy, dpnp]) | ||
| def test_out_wrong_tuple_len(self, xp, func): |
Contributor
There was a problem hiding this comment.
What is the point to move the test from TestUfunc scope to TestRoundingFuncs?
Contributor
Author
There was a problem hiding this comment.
dpnp.fix no longer exposes .nin and .nout so I removed it from TestUfunc and added test_out_wrong_tuple_len to TestRoundingFuncs to keep the coverage and extend this case for rounding functions
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_48 ran successfully. |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites
dpnp.fixto reusedpnp.truncinternally removing the backend implementation ofdpnp.fixand aligning the documentation with NumPy