Skip to content

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 26, 2026

The PR aligns with recent change in NumPy and adds more clarity on the description of the file positional argument on dpnp.fromfile documentation.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Jan 26, 2026
@antonwolfy antonwolfy self-assigned this Jan 26, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2026

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2026

Array API standard conformance tests for dpnp=0.20.0dev2=py313h509198e_11 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Jan 26, 2026

Coverage Status

coverage: 81.104%. remained the same
when pulling 95b83b1 on improve-fromfile-docstring
into 8e0213d on master.

Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit b910c92 into master Jan 27, 2026
94 of 118 checks passed
@antonwolfy antonwolfy deleted the improve-fromfile-docstring branch January 27, 2026 14:39
github-actions bot added a commit that referenced this pull request Jan 27, 2026
The PR aligns with recent change in NumPy and adds more clarity on the
description of the `file` positional argument on `dpnp.fromfile`
documentation. b910c92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants