Skip to content

Use dpctl_capi.h header in dpnp4pybind11.hpp#2859

Open
vlad-perevezentsev wants to merge 2 commits intoinclude-dpctl-tensorfrom
use-dpctl-capi-header
Open

Use dpctl_capi.h header in dpnp4pybind11.hpp#2859
vlad-perevezentsev wants to merge 2 commits intoinclude-dpctl-tensorfrom
use-dpctl-capi-header

Conversation

@vlad-perevezentsev
Copy link
Copy Markdown
Contributor

This PR proposes replacing the individual dpctl C-API includes and import calls in dpnp4pybind11.hpp with dpctl_capi.h header and its import_dpctl() function.
Previous changes to the explicit imports were made to avoid conflicting with dpctl which contained a tensor;
now that dpctl no longer contains a tensor, we can use the header directly.

Additionally, fixes RuntimeWarning filter in test_exp_complex_contig

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@github-actions
Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2859/index.html

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

Coverage is 77.873%use-dpctl-capi-header into include-dpctl-tensor. No base build found for include-dpctl-tensor.

@github-actions
Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.20.0dev6=py313h509198e_59 ran successfully.
Passed: 1355
Failed: 5
Skipped: 16

Copy link
Copy Markdown
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants