Resolve gh-2882#2930
Open
ndgrigorian wants to merge 6 commits into
Open
Conversation
float to unsigned integer casts could encounter undefined behavior when the float passes through a signed integral type, where the intermediate signed integral type could overflow
ndgrigorian
added a commit
that referenced
this pull request
May 22, 2026
758c3e1 to
f025367
Compare
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2930/index.html |
Collaborator
|
coverage: 78.237% (-0.002%) from 78.239% — resolve-gh-2882 into master |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev0=py313h509198e_48 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a fix for gh-2882
When floats were previously converted by
convert_implto unsigned integral types, they would pass through an equally sized, signed integral typeIf the float was in bounds for the unsigned integral type but out of bounds for the signed type, however, undefined behavior could be encountered.
This PR proposes a solution of casting to a sufficiently large intermediate type first, before casting into the unsigned integral type.