Optimize FFT logic for complex strided input to avoid oversized memory allocation#2939
Open
vlad-perevezentsev wants to merge 3 commits into
Open
Optimize FFT logic for complex strided input to avoid oversized memory allocation#2939vlad-perevezentsev wants to merge 3 commits into
vlad-perevezentsev wants to merge 3 commits into
Conversation
7 tasks
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2939/index.html |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue discovered while implementing #2927 where several FFT tests started failing after adding validation for stride configurations with oversized memory footprints.
The problem was that FFT could allocate output arrays using the same strided layout as a non-contiguous input. For inputs such as
a[::2, this resulted in oversized allocations followed by an additional copy to a contiguous array.This fix checks whether the memory footprint implied by the input strides exceeds the number of elements in the array. If so, the input is copied to a contiguous layout before configuring the FFT descriptor allowing oneMKL FFT to produce a contiguous output directly
By avoiding oversized allocations and the extra copy this significantly improves the performance of all FFT operations in dpnp with complex strided inputs