Skip to content

[MAINT] Add to pre-commit#157

Merged
ndgrigorian merged 4 commits intomasterfrom
add-to-pre-commit
Mar 6, 2026
Merged

[MAINT] Add to pre-commit#157
ndgrigorian merged 4 commits intomasterfrom
add-to-pre-commit

Conversation

@ndgrigorian
Copy link
Copy Markdown
Collaborator

This PR expands the number of pre-commit checks to align mkl-service with the other mkl packages,

Copilot AI review requested due to automatic review settings March 5, 2026 16:07
@ndgrigorian ndgrigorian changed the title [MAINT] Add to pre commit [MAINT] Add to pre-commit Mar 5, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the pre-commit hook configuration for mkl-service to align with other mkl packages, adding new security and linting checks. It also fixes shell quoting issues across CI workflows identified by the newly added shellcheck enforcement.

Changes:

  • Adds new pre-commit hooks: check-added-large-files, no-commit-to-branch, check-illegal-windows-names, gitleaks (secret scanning), and actionlint (GitHub Actions linting).
  • Fixes shell quoting issues in CI workflows (conda-package.yml, build-with-clang.yml) to correctly handle paths with spaces and use bash arrays for multi-word arguments, resolving shellcheck warnings.
  • Updates .git-blame-ignore-revs to record this commit for git blame purposes.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.pre-commit-config.yaml Adds five new hooks (large files, branch protection, Windows name checks, gitleaks, actionlint); introduces a duplicate check-case-conflict entry
.github/workflows/pre-commit.yml Fixes shell quoting; contains a mismatch between the clang-format version installed and the symlink target
.github/workflows/conda-package.yml Converts unquoted shell variables to properly quoted strings and bash arrays; adds shell: cmd to a Windows step; expands inline channel lists
.github/workflows/build-with-clang.yml Adds shell quoting around $CMPLR_ROOT usages
.git-blame-ignore-revs Records this commit SHA to exclude it from git blame output

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .pre-commit-config.yaml
Comment thread .github/workflows/pre-commit.yml Outdated
@antonwolfy antonwolfy added this to the 2.7.0 release milestone Mar 5, 2026
Copy link
Copy Markdown
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian

@ndgrigorian ndgrigorian merged commit 9b1babd into master Mar 6, 2026
79 of 81 checks passed
@ndgrigorian ndgrigorian deleted the add-to-pre-commit branch March 6, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants