Remove CBWR constants which are being dropped by MKL#173
Merged
ndgrigorian merged 3 commits intomasterfrom Apr 8, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates mkl-service’s Conditional Numerical Reproducibility (CBWR/CNR) support to align with Intel oneMKL dropping several deprecated CBWR constants, removing those constants from the Cython MKL header declarations and the Python-facing branch mappings.
Changes:
- Removed dropped CBWR constants from the
mkl.hCython declarations (.pxd). - Removed corresponding CBWR branch keyword mappings from
cbwr_set,cbwr_get, andcbwr_get_auto_branch(.pyx).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
mkl/_mkl_service.pyx |
Removes dropped CBWR branch keyword mappings from CNR helper functions. |
mkl/_mkl_service.pxd |
Removes dropped CBWR constant declarations to prevent build issues with newer MKL headers. |
ndgrigorian
force-pushed
the
drop-removed-cbwr-constants
branch
from
ab1b5fc to
57e5110
Compare
antonwolfy
reviewed
Apr 8, 2026
ndgrigorian
force-pushed
the
drop-removed-cbwr-constants
branch
from
1aa25c8 to
95b29f9
Compare
Collaborator
Author
|
build_linux failures are transient HTTP failures and can be ignored |
jharlow-intel
approved these changes
Apr 8, 2026
Collaborator
jharlow-intel
left a comment
jharlow-intel
left a comment
There was a problem hiding this comment.
LGTM! Thanks @ndgrigorian
antonwolfy
approved these changes
Apr 8, 2026
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @ndgrigorian
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes removing the CBWR constants which were deprecated (in documentation) and are being removed by MKL