Merged
Conversation
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
ndgrigorian
force-pushed
the
add-missing-isa-constants
branch
from
a8d1aa7 to
9ca260c
Compare
ndgrigorian
added a commit
that referenced
this pull request
Apr 8, 2026
also refactors enable_instructions test
ndgrigorian
force-pushed
the
add-missing-isa-constants
branch
from
a287b4e to
b63c9c1
Compare
antonwolfy
reviewed
Apr 8, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates mkl-service’s Cython bindings and tests to recognize additional oneMKL instruction set architecture (ISA) and CNR/CBWR branch identifiers, addressing gaps found while removing deprecated CNR constants.
Changes:
- Added
avx10support to CBWR (CNR) branch mappings (cbwr_set/cbwr_get/cbwr_get_auto_branch). - Added
avx10andavx512_e5support toenable_instructionsISA mapping. - Refactored
enable_instructionstests into a single parametrized test and expanded coverage to include the new ISA strings.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
mkl/tests/test_mkl_service.py |
Adds avx10 CBWR branches and refactors/extends enable_instructions tests via parametrization. |
mkl/_mkl_service.pyx |
Extends string→MKL constant mappings for CBWR and ISA (avx10, avx512_e5). |
mkl/_mkl_service.pxd |
Declares additional MKL header constants needed by the new mappings. |
CHANGELOG.md |
Documents the newly supported ISA / CBWR strings in the dev changelog. |
antonwolfy
approved these changes
Apr 8, 2026
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @ndgrigorian, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing ISA constants pointed out when dropping deprecated CNR constants
Also refactors
enable_instructionstest to (slightly) simplify this process in the future