Skip to content

Add mkl dependency#177

Merged
ndgrigorian merged 3 commits intomasterfrom
add-mkl-dependency
Apr 10, 2026
Merged

Add mkl dependency#177
ndgrigorian merged 3 commits intomasterfrom
add-mkl-dependency

Conversation

@ndgrigorian
Copy link
Copy Markdown
Collaborator

This PR proposes adding mkl to pyproject.toml as a runtime dependency, and mkl-devel as a build-system dependency. This aligns pyproject.toml with the meta.yaml.

Slips in change removing unneeded travis.yml

Copilot AI review requested due to automatic review settings April 9, 2026 23:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns pyproject.toml dependency metadata with the conda recipe by declaring MKL-related dependencies, and removes legacy Travis CI configuration.

Changes:

  • Add mkl-devel to build-system.requires in pyproject.toml.
  • Add mkl to [project].dependencies in pyproject.toml.
  • Remove the obsolete .travis.yml file.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pyproject.toml Adds MKL build/runtime dependencies to project metadata.
.travis.yml Deletes legacy Travis CI configuration.

Comment thread pyproject.toml
Comment thread pyproject.toml
@antonwolfy antonwolfy added this to the 2.7.0 release milestone Apr 10, 2026
Copy link
Copy Markdown
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian
The only small nit from me is to populate the changelog

@ndgrigorian ndgrigorian merged commit 44dcb11 into master Apr 10, 2026
104 checks passed
@ndgrigorian ndgrigorian deleted the add-mkl-dependency branch April 10, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants