Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Aligns pyproject.toml dependency metadata with the conda recipe by declaring MKL-related dependencies, and removes legacy Travis CI configuration.
Changes:
- Add
mkl-develtobuild-system.requiresinpyproject.toml. - Add
mklto[project].dependenciesinpyproject.toml. - Remove the obsolete
.travis.ymlfile.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Adds MKL build/runtime dependencies to project metadata. |
| .travis.yml | Deletes legacy Travis CI configuration. |
antonwolfy
approved these changes
Apr 10, 2026
Collaborator
There was a problem hiding this comment.
Thank you @ndgrigorian
The only small nit from me is to populate the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes adding
mkltopyproject.tomlas a runtime dependency, andmkl-develas a build-system dependency. This alignspyproject.tomlwith themeta.yaml.Slips in change removing unneeded
travis.yml