Remove test for importing mkl_fft interfaces from conda recipe
#241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes problematic import tests from the conda recipe that were failing due to missing scipy dependency during the test phase. The imports of mkl_fft.interfaces.numpy_fft and mkl_fft.interfaces.scipy_fft are removed from the test section, while the parent module mkl_fft.interfaces import is retained.
Key changes:
- Removed two specific interface import tests that require scipy to be present
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ndgrigorian
force-pushed
the
remove-interfaces-from-conda-recipe
branch
from
1444314 to
18c44e9
Compare
Contributor
|
this looks good to me, we'll move that import smoke tests to somewhere else in the CI |
Collaborator
Author
|
@antonwolfy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem when building
mkl_fftusing the conda recipe, where importing the interfaces would be tested without scipy in the environment (though it is listed as a test dependency)The conda recipe section for testing the import of
mkl_fft.interfaces.scipy_fftandmkl_fft.interfaces.numpy_fftis removed