Merged
Conversation
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
these are for various regressions
ndgrigorian
force-pushed
the
add-more-tests-for-interfaces
branch
from
757c278 to
d317543
Compare
antonwolfy
reviewed
Apr 9, 2026
test_regression tests were vendored from numpy but outdated and harder to maintain also remove vendored regression tests from test_numpy_random
ndgrigorian
force-pushed
the
add-more-tests-for-interfaces
branch
from
d6645d9 to
cf587c0
Compare
antonwolfy
approved these changes
Apr 10, 2026
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
No more comments from me.
It would be good also to note changes in multinomial, permutation, and randint function in the changelog.
Collaborator
Author
|
@antonwolfy |
antonwolfy
approved these changes
Apr 10, 2026
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @ndgrigorian
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes adding more tests vendored from NumPy's
random/tests. These tests are specifically vendored from tests for regressions inRandomStateThe tests exposed some issues in
multinomial,permutation, andrandint, which were solved in the scope of this PR