Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Demo refactoring#299

Merged
shssf merged 2 commits intoIntelPython:masterfrom
akharche:sdc_demo
Nov 15, 2019
Merged

Demo refactoring#299
shssf merged 2 commits intoIntelPython:masterfrom
akharche:sdc_demo

Conversation

@akharche
Copy link
Copy Markdown
Contributor

No description provided.

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Nov 15, 2019

Hello @akharche! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 7:1: E122 continuation line missing indentation or outdented
Line 15:1: W191 indentation contains tabs
Line 15:16: E231 missing whitespace after ':'
Line 16:1: W191 indentation contains tabs
Line 16:12: E231 missing whitespace after ':'
Line 16:121: E501 line too long (122 > 120 characters)
Line 17:1: W191 indentation contains tabs
Line 17:12: E231 missing whitespace after ':'
Line 18:1: W191 indentation contains tabs
Line 18:12: E231 missing whitespace after ':'
Line 25:1: W191 indentation contains tabs
Line 45:1: W191 indentation contains tabs
Line 46:1: W191 indentation contains tabs
Line 47:1: W191 indentation contains tabs
Line 48:1: W191 indentation contains tabs
Line 48:1: W293 blank line contains whitespace
Line 49:1: W191 indentation contains tabs
Line 51:1: W191 indentation contains tabs
Line 52:1: W191 indentation contains tabs
Line 52:4: E117 over-indented
Line 53:1: W191 indentation contains tabs
Line 54:1: W191 indentation contains tabs
Line 54:4: E128 continuation line under-indented for visual indent
Line 55:1: W191 indentation contains tabs
Line 55:4: E128 continuation line under-indented for visual indent
Line 57:1: W191 indentation contains tabs
Line 58:1: W191 indentation contains tabs
Line 59:1: W191 indentation contains tabs
Line 59:4: E117 over-indented
Line 60:1: W191 indentation contains tabs
Line 62:1: W191 indentation contains tabs
Line 66:1: W191 indentation contains tabs
Line 67:1: W191 indentation contains tabs
Line 67:4: E117 over-indented
Line 69:1: W191 indentation contains tabs
Line 70:1: W191 indentation contains tabs

Comment last updated at 2019-11-15 17:00:55 UTC

Copy link
Copy Markdown
Contributor

@shssf shssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this will require mode work after #297 merged

@shssf shssf merged commit 0369309 into IntelPython:master Nov 15, 2019
@akharche akharche deleted the sdc_demo branch November 18, 2019 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants