Fix series perf tests in new style#339
Conversation
|
Hello @1e-to! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-12-01 19:40:49 UTC |
densmirn
left a comment
densmirn
left a comment
There was a problem hiding this comment.
Thanks for this PR. Some changes to be applied before merge.
| if id not in list(sort[len(self._data) - na:]): | ||
| result[id] = sort_nona[id-q] | ||
| else: | ||
| if id in list(sort[len(self._data) - na:]): |
There was a problem hiding this comment.
Not the best name sort for the Python variable. Why do you use constructor list() here? Is it exactly required?
| if id in list(sort[len(self._data) - na:]): | ||
| q += 1 | ||
| else: | ||
| result[id] = sort_nona[id-q] |
There was a problem hiding this comment.
Please follow PEP8 recommendation: "Always surround these binary operators with a single space on either side".
| if id in list(sort[len(self._data) - na:]): | ||
| q += 1 | ||
| else: | ||
| result[id] = sort_nona[id - q] |
There was a problem hiding this comment.
The same comments as above.
4 participants
No description provided.