extended test mode for benchmarks#352
Conversation
samir-nasibli
commented
Nov 28, 2019
- extended test mode by adding benchmark mode
* extended test mode, added benchmark mode
|
Seems we need to add opportunity to run the performance tests under multiple threads by setting environment variables |
@densmirn , |
|
@densmirn @Vyacheslav-Smirnov |
|
@densmirn , Can we make benchmarks to output results in csv instead of excel? |
|
@densmirn I have the same question: what is the purpose of LOAD_PREV_RESULTS and what is should point to? It seems that currently excel files are overwriting without aggregation of recent results |
|
@densmirn @Vyacheslav-Smirnov @dmitrii-zagornyi aggregating results in csv is much preferable in the task of integration benchmarks into CI, isn't it? also this would avoid additional dependencies |
* update TestResults class's dump method by adding ability to save performance testing results into html files
Maybe it makes sense to remove the file before the next series of run. |
In case if we want to get CSV results we need to wait #347. |
|
|
||
| class TestResults: | ||
| perf_results_xlsx = 'perf_results.xlsx' | ||
| perf_results_html = 'perf_results.html' |
There was a problem hiding this comment.
I vote for waiting for #347 to apply these changes over this PR.
There was a problem hiding this comment.
@densmirn , @PokhodenkoSA ,
Then I think result's dump to html should be implemented in #347
And in current PR we can revert changes with html and merge it.
There was a problem hiding this comment.
Please resolve merge conflicts.