Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Skip hanging tests in test_basic#359

Merged
PokhodenkoSA merged 2 commits intoIntelPython:masterfrom
PokhodenkoSA:sdc-self-jit
Dec 2, 2019
Merged

Skip hanging tests in test_basic#359
PokhodenkoSA merged 2 commits intoIntelPython:masterfrom
PokhodenkoSA:sdc-self-jit

Conversation

@PokhodenkoSA
Copy link
Copy Markdown
Contributor

This PR fixes #351. There are some difference between sdc.jit and numba.jit:

  1. sdc.jit do not set parallel=True.

@PokhodenkoSA
Copy link
Copy Markdown
Contributor Author

One test in old pipeline - test_str_split_filter - fails because #321.

@pep8speaks
Copy link
Copy Markdown

Hello @PokhodenkoSA! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 47:36: E127 continuation line over-indented for visual indent

@densmirn
Copy link
Copy Markdown
Contributor

densmirn commented Dec 2, 2019

Hello @PokhodenkoSA! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 47:36: E127 continuation line over-indented for visual indent

Could you fix the indentations issue?

@PokhodenkoSA
Copy link
Copy Markdown
Contributor Author

Could you fix the indentations issue?

Not in this PR. This code is inline with other lines before.
I think introducing new style is better with one big PR with autostyling tool like black. Otherwise it will confuse people.

@PokhodenkoSA PokhodenkoSA merged commit b54efef into IntelPython:master Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants