Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Sum/nansum numpy-like impl#570

Merged
AlexanderKalistratov merged 7 commits intoIntelPython:masterfrom
1e-to:sum_nansum
Feb 10, 2020
Merged

Sum/nansum numpy-like impl#570
AlexanderKalistratov merged 7 commits intoIntelPython:masterfrom
1e-to:sum_nansum

Conversation

@1e-to
Copy link
Copy Markdown
Contributor

@1e-to 1e-to commented Feb 6, 2020

No description provided.

@1e-to 1e-to requested a review from PokhodenkoSA February 6, 2020 08:19
@1e-to
Copy link
Copy Markdown
Contributor Author

1e-to commented Feb 6, 2020

@PokhodenkoSA
Copy link
Copy Markdown
Contributor

Perfomance: https://teamcity-or.intel.com/buildConfiguration/Sat_Sdc_Linux_SdcPy37numpy116_Testing_SdcBenchmarks?branch=570%2Fmerge&buildTypeTab=overview

Can not open and see results. Could you, please, attach results screenshot?

Comment thread sdc/functions/numpy_like.py Outdated
length = len(a)
result = 0
for i in prange(length):
if not numpy.isnan(a[i]):
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use here get_isnan @PokhodenkoSA knows the details

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexanderKalistratov
Copy link
Copy Markdown
Collaborator

@1e-to conflict

1 similar comment
@AlexanderKalistratov
Copy link
Copy Markdown
Collaborator

@1e-to conflict

@AlexanderKalistratov AlexanderKalistratov merged commit 78b03a1 into IntelPython:master Feb 10, 2020
@1e-to 1e-to deleted the sum_nansum branch February 12, 2020 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants