This repository was archived by the owner on Feb 2, 2024. It is now read-only.
add functions for gen data, args, base. simplification _test_case #572
Merged
densmirn merged 19 commits intoIntelPython:masterfrom Feb 11, 2020
Merged
add functions for gen data, args, base. simplification _test_case #572densmirn merged 19 commits intoIntelPython:masterfrom
densmirn merged 19 commits intoIntelPython:masterfrom
Conversation
densmirn
reviewed
Feb 6, 2020
| datas = gen_data(data_num, data_length, input_data) | ||
| args = [] | ||
| for data in datas: | ||
| test_data = pandas.DataFrame({f"f{i}": data for i in range(3)}) |
Contributor
There was a problem hiding this comment.
I vote for passing number of columns as an argument of DF generator with some default value.
Comment on lines
+32
to
+33
| datas = gen_str_data(data_num, data_length, input_data, data_width) | ||
| args = [] |
Contributor
There was a problem hiding this comment.
I would rename datas to all_data, args to results everywhere.
Contributor
There was a problem hiding this comment.
@Rubtsowa you didn't apply the renaming everywhere.
PokhodenkoSA
approved these changes
Feb 7, 2020
densmirn
approved these changes
Feb 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.