This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Add Boolean handling to Series.value_counts #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akharche
requested review from
AlexanderKalistratov and
densmirn
and removed request for
densmirn
densmirn
reviewed
Feb 13, 2020
sdc/tests/test_series.py
Outdated
| result = hpat_func(S).sort_index() | ||
| pd.testing.assert_series_equal(result, result_ref) | ||
|
|
||
| @skip_sdc_jit |
Contributor
There was a problem hiding this comment.
Could you add a reason why is the test skipped: @skip_sdc_jit('The reason')
sdc/tests/test_series.py
Outdated
|
|
||
| hpat_func = self.jit(test_impl) | ||
|
|
||
| for data_to_test in input_data: |
Contributor
There was a problem hiding this comment.
Do you exactly need the loop with a single iteration?
densmirn
approved these changes
Feb 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.