Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Add Boolean handling to Series.value_counts #596

Merged
merged 3 commits into from
Feb 16, 2020
Merged

Add Boolean handling to Series.value_counts #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71aaafb
Add Boolean handling to Series.value_counts
akharche Feb 13, 2020
c3e1cf5
Refactor test
akharche Feb 13, 2020
b0e32ed
Remove index sorting
akharche Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdc/datatypes/hpat_pandas_series_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1369,7 +1369,7 @@ def hpat_pandas_series_value_counts_str_impl(

return hpat_pandas_series_value_counts_str_impl

elif isinstance(self.dtype, types.Number):
elif isinstance(self.dtype, (types.Number, types.Boolean)):

series_dtype = self.dtype
def hpat_pandas_series_value_counts_number_impl(
Expand Down
14 changes: 14 additions & 0 deletions sdc/tests/test_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2590,6 +2590,20 @@ def test_impl(S):
result = hpat_func(S).sort_index()
pd.testing.assert_series_equal(result, result_ref)

@skip_sdc_jit('Fails to compile with latest Numba')
def test_series_value_counts_boolean(self):
def test_impl(S):
return S.value_counts()

input_data = [True, False, True, True, False]

sdc_func = self.jit(test_impl)

S = pd.Series(input_data)
result_ref = test_impl(S)
result = sdc_func(S)
pd.testing.assert_series_equal(result, result_ref)

@skip_sdc_jit('Bug in old-style value_counts implementation for ascending param support')
def test_series_value_counts_sort(self):
def test_impl(S, value):
Expand Down