Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

fixing typing for InlineClosureCallPass#84

Merged
ehsantn merged 1 commit intoIntelPython:masterfrom
esc:fix_InlineClosureCallPass
Apr 26, 2019
Merged

fixing typing for InlineClosureCallPass#84
ehsantn merged 1 commit intoIntelPython:masterfrom
esc:fix_InlineClosureCallPass

Conversation

@esc
Copy link
Copy Markdown
Contributor

@esc esc commented Apr 26, 2019

We recently detected integration testing failures with the latest Numba
master and the latest released version of HPAT.

Specifically, the following error was raised:

======================================================================
FAIL: test_kmeans (hpat.tests.test_ml.TestML)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/circleci/repo/miniconda3/envs/hpat/lib/python3.6/site-packages/hpat/tests/test_ml.py", line 110, in test_kmeans
    self.assertEqual(count_array_OneDs(), 4)
AssertionError: 0 != 4

A CI build log can be found here:

https://circleci.com/gh/numba/numba-integration-testing/24

Using git bisect the following offending commit was detected in the
Numba Git history:

e5d8a41e15d4bbb7f2b81859dab210c9abdf8ccc is the first bad commit

And this was then traced to the following pull-request:

numba/numba#3884

The problem here is, that InlineClosureCallPass was equipped with a new
keyword argument typed which defaults to False bzut should be True
in this case.

This patch fixes that and makes the test-suite pass once again.

We recently detected integration testing failures with the latest Numba
master and the latest released version of HPAT.

Specifically, the following error was raised:

```
======================================================================
FAIL: test_kmeans (hpat.tests.test_ml.TestML)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/circleci/repo/miniconda3/envs/hpat/lib/python3.6/site-packages/hpat/tests/test_ml.py", line 110, in test_kmeans
    self.assertEqual(count_array_OneDs(), 4)
AssertionError: 0 != 4
```

A CI build log can be found here:

https://circleci.com/gh/numba/numba-integration-testing/24

Using `git bisect` the following offending commit was detected in the
Numba Git history:

`e5d8a41e15d4bbb7f2b81859dab210c9abdf8ccc is the first bad commit`

And this was then traced to the following pull-request:

numba/numba#3884

The problem here is, that `InlineClosureCallPass` was equipped with a new
keyword argument `typed` which defaults to `False` bzut should be `True`
in this case.

This patch fixes that and makes the test-suite pass once again.
@ehsantn
Copy link
Copy Markdown
Contributor

ehsantn commented Apr 26, 2019

Thank you, @esc . Makes sense.

@ehsantn ehsantn merged commit 30d650a into IntelPython:master Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants