This repository was archived by the owner on Feb 2, 2024. It is now read-only.
fixing typing for InlineClosureCallPass#84
Merged
ehsantn merged 1 commit intoIntelPython:masterfrom Apr 26, 2019
esc:fix_InlineClosureCallPass
Merged
fixing typing for InlineClosureCallPass#84ehsantn merged 1 commit intoIntelPython:masterfrom esc:fix_InlineClosureCallPass
ehsantn merged 1 commit intoIntelPython:masterfrom
esc:fix_InlineClosureCallPass
Conversation
We recently detected integration testing failures with the latest Numba
master and the latest released version of HPAT.
Specifically, the following error was raised:
```
======================================================================
FAIL: test_kmeans (hpat.tests.test_ml.TestML)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/circleci/repo/miniconda3/envs/hpat/lib/python3.6/site-packages/hpat/tests/test_ml.py", line 110, in test_kmeans
self.assertEqual(count_array_OneDs(), 4)
AssertionError: 0 != 4
```
A CI build log can be found here:
https://circleci.com/gh/numba/numba-integration-testing/24
Using `git bisect` the following offending commit was detected in the
Numba Git history:
`e5d8a41e15d4bbb7f2b81859dab210c9abdf8ccc is the first bad commit`
And this was then traced to the following pull-request:
numba/numba#3884
The problem here is, that `InlineClosureCallPass` was equipped with a new
keyword argument `typed` which defaults to `False` bzut should be `True`
in this case.
This patch fixes that and makes the test-suite pass once again.
Contributor
|
Thank you, @esc . Makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently detected integration testing failures with the latest Numba
master and the latest released version of HPAT.
Specifically, the following error was raised:
A CI build log can be found here:
https://circleci.com/gh/numba/numba-integration-testing/24
Using
git bisectthe following offending commit was detected in theNumba Git history:
e5d8a41e15d4bbb7f2b81859dab210c9abdf8ccc is the first bad commitAnd this was then traced to the following pull-request:
numba/numba#3884
The problem here is, that
InlineClosureCallPasswas equipped with a newkeyword argument
typedwhich defaults toFalsebzut should beTruein this case.
This patch fixes that and makes the test-suite pass once again.