SAT-2966 - SDC: test_series_operator_lt_str fails on Linux 3.6 #884
Conversation
|
Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-06-16 10:57:54 UTC |
kozlov-alexey
force-pushed
the
bugfix/comp_binops_fill_value
branch
from
6433e1a to
5ea6970
Compare
|
Tested full series suite on python 3.6. and with this fix it passed: |
sdc/tests/test_sdc_numpy.py
Outdated
| with self.subTest(data=case): | ||
| np.testing.assert_array_equal(ref_impl(array0), sdc_func(array1)) | ||
|
|
||
| def test_fillna_numeric_inplace_false(self): |
There was a problem hiding this comment.
You could combine tests test_fillna_numeric_inplace_false and test_fillna_numeric_inplace_true by moving generic code to separate method something like that:
def _test_fillna_numeric_inplace(self, pyfunc, cfunc):
# generic codeThen call the method in the tail of both tests.
There was a problem hiding this comment.
@densmirn The assertion code block of these tests are not identical (inplace=True methods modify original arrays), so this new _test_fillna_numeric func has to accept inplace arg and alter behavior based on it's value (made it this way).
4 participants
No description provided.