Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Conversation

@Vyacheslav-Smirnov
Copy link
Contributor

@Vyacheslav-Smirnov Vyacheslav-Smirnov commented Jan 20, 2021

  • Update wheels build procedure - align with other packages; current build via conda output does not support required additional options
  • Use manylinux1 for Python 3.6
  • Use manylinux2014 for Python > 3.6

@Vyacheslav-Smirnov
Copy link
Contributor Author

Vyacheslav-Smirnov commented Feb 1, 2021

Mac build fails on gold/2021 branch also. I do not think that it is caused by current changes.
So I propose to merge this PR.
@xaleryb , @kozlov-alexey - what do you think about it?

@Vyacheslav-Smirnov Vyacheslav-Smirnov changed the title [WIP] Update wheels build + Update linux build tag for wheels Update wheels build + Update linux build tag for wheels Feb 1, 2021
- {{ compiler('cxx') }} # [not osx]
- wheel
- python
- numba {{ NUMBA_VERSION }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numba recently became a build dependency for sdc, so it's better to keep it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's keep numba here

imports:
- sdc

outputs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to remove 'outputs' section at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the purpose of this PR is to align wheels build procedure with others packages.
Here was used conda output - it does not suits for us due to we cannot set additional arguments for wheels build.
That is why output section is removed and wheel build lines are added in build.sh and bld.bat

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants