-
Notifications
You must be signed in to change notification settings - Fork 62
Update wheels build + Update linux build tag for wheels #954
Conversation
|
Mac build fails on gold/2021 branch also. I do not think that it is caused by current changes. |
| - {{ compiler('cxx') }} # [not osx] | ||
| - wheel | ||
| - python | ||
| - numba {{ NUMBA_VERSION }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Numba recently became a build dependency for sdc, so it's better to keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's keep numba here
| imports: | ||
| - sdc | ||
|
|
||
| outputs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to remove 'outputs' section at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the purpose of this PR is to align wheels build procedure with others packages.
Here was used conda output - it does not suits for us due to we cannot set additional arguments for wheels build.
That is why output section is removed and wheel build lines are added in build.sh and bld.bat
…elPython/sdc into update_linux_wheel_build_tag
Uh oh!
There was an error while loading. Please reload this page.