Skip to content

Conversation

@Joshua-Lester3
Copy link
Collaborator

Description

The book image showing the Essential C# 12.0 cover is now clickable. Clicking it opens Amazon's page for the book.

No open issue for this.

Ensure that your pull request has followed all the steps below:

  • Code compilation
  • Created tests which fail without the change (if possible) - N/A
  • All tests passing - EssentialCSharp.Web.Tests.FunctionalTests.WhenTheApplicationStarts_ItCanLoadLoadPages(relativeUrl: "/guidelines") does not pass. I believe it's supposed to be pulling from EssentialCSharp.Web/Guidelines/guidelines.json but that does not exist. I'm not sure where it comes from, but I'm going to assume it's handled elsewhere.
  • Extended the README / documentation, if necessary - N/A

@BenjaminMichaelis BenjaminMichaelis changed the title Book image on home page now directs to book's Amazon page feat: Book image on home page now directs to book's Amazon page Oct 7, 2024
Copy link
Member

@BenjaminMichaelis BenjaminMichaelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

Let's :shipit:

@BenjaminMichaelis BenjaminMichaelis enabled auto-merge (squash) October 7, 2024 22:55
auto-merge was automatically disabled October 7, 2024 23:22

Pull request was closed

@BenjaminMichaelis BenjaminMichaelis enabled auto-merge (squash) October 7, 2024 23:22
@BenjaminMichaelis BenjaminMichaelis merged commit cd30c8b into IntelliTect:main Oct 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants