Skip to content

Fix targets and update tests #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 27, 2022
Merged

Fix targets and update tests #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0e7834
Update nuget packages
BenjaminMichaelis Jul 26, 2022
c7bd844
Make tests more robust
BenjaminMichaelis Jul 26, 2022
5b03f15
Update readme badge
BenjaminMichaelis Jul 26, 2022
8f14f85
Update Visual Studio version
BenjaminMichaelis Jul 26, 2022
2a1340a
Merge branch 'v9.0' into FixTargetsAndUpdateTests
BenjaminMichaelis Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# EssentialCSharp
[![Build and Test v9.0](https://github.com/IntelliTect/EssentialCSharp/actions/workflows/Branch%20v9.0.yml/badge.svg)](https://github.com/IntelliTect/EssentialCSharp/actions/workflows/Branch%20v9.0.yml)
[![Build and Test v9.0](https://github.com/IntelliTect/EssentialCSharp/actions/workflows/Branch%20v9.0.yml/badge.svg?branch=v9.0&event=push)](https://github.com/IntelliTect/EssentialCSharp/actions/workflows/Branch%20v9.0.yml)

This project contains the source code for the book **Essential C#** by Mark Michaelis (Addison-Wesley).

Expand Down
4 changes: 2 additions & 2 deletions src/Chapter03.Tests/Chapter03.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
<Compile Include="..\Shared\CompilerAssert.cs" Link="CompilerAssert.cs" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Scripting" Version="4.0.1" />
<PackageReference Include="Microsoft.CodeAnalysis.Scripting.Common" Version="4.0.1" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Scripting" Version="4.2.0" />
<PackageReference Include="Microsoft.CodeAnalysis.Scripting.Common" Version="4.2.0" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Chapter03\Chapter03.csproj" />
Expand Down
4 changes: 2 additions & 2 deletions src/Chapter03.Tests/Listing03.02.DereferencingAnUnassignedVariable.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ public class UppercaseTests
[TestMethod]
async public Task UnassignedVariableThrowsError()
{
CompileError[] compileErrors = await CompilerAssert.ExpectErrorsInFileAsync(
_ = await CompilerAssert.ExpectErrorsInFileAsync(
"Listing03.02.DereferencingAnUnassignedVariable.cs",
new CompileError("CS0165: Use of unassigned local variable 'text'"));
new CompileError("CS0165", "Use of unassigned local variable 'text'"));
}
}
}
8 changes: 1 addition & 7 deletions src/Shared/CompilerAssert.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,16 +105,10 @@ async static public Task<CompileError[]> ExpectErrorsAsync(
for (int i = 0; i < actualCompileErrors.Length; i++)
{
// Compare Id's first as that is more meaningful.
Assert.AreEqual<string>(diagnostics[i].Message, actualCompileErrors[i].Message,
$"The expected Messages do not match for item {i}: " +
$"{diagnostics[i].Message} <> {diagnostics[i].Message}");
Assert.AreEqual<string>(diagnostics[i].Id, actualCompileErrors[i].Id,
$"The expected Ids do not match for item {i}: " +
$"{diagnostics[i].Id} <> {actualCompileErrors[i].Id}");
$"{diagnostics[i].Id}: {diagnostics[i].Message} <> {actualCompileErrors[i].Id}: {actualCompileErrors[i].Message}");
}
//CollectionAssert.AreEquivalent(
// diagnostics,
// actualCompileErrors.ToList());
}
return actualCompileErrors;
}
Expand Down