1.21.1 RS Bridge to RS2 port#684
Merged
Merged
Conversation
…n from 0.8 to reduce breaking changes when we port 0.8 to future versions, we will also use that for the me bridge in the near future Some functions implemented for testing
Contributor
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
# Conflicts: # src/generated/resources/.cache/2f719b8031aed5e605ed8d6694b19245ca45c6ca # src/generated/resources/.cache/b8526e444ae7356037f3a813274f6835d1f3dd16 # src/main/java/de/srendi/advancedperipherals/common/data/BlockStatesAndModelsProvider.java
Bump RS
…redPatterns` and add the filter option to `getPatterns`
…d external storages with chemical support
… methods nullable to support both at once
…The items can be requested, but we are currently unable to give the players more information - already in discussion with the rs2 maintainer
… fixed that it would not have a crafting task to get information. Now needs major testing and refinement
… now. We may change some api design before we release the update
zyxkad
requested changes
Apr 28, 2025
zyxkad
reviewed
Apr 28, 2025
zyxkad
reviewed
Apr 28, 2025
zyxkad
reviewed
Apr 28, 2025
…ashes when the rs mekanism addon is not installed
…stry, before we created a new holder instead of getting one from the registry
Add a crafted and resource attribute to the crafting task object
zyxkad
reviewed
Apr 30, 2025
…don is not loaded
zyxkad
requested changes
May 4, 2025
…nedstorage/RSFluidHandler.java Co-authored-by: Kevin Z <zyxkad@gmail.com> Signed-off-by: Srendi <info@denizdemiroglu.de>
Signed-off-by: Kevin Z <zyxkad@gmail.com>
zyxkad
reviewed
May 4, 2025
Signed-off-by: Kevin Z <zyxkad@gmail.com>
zyxkad
reviewed
May 5, 2025
zyxkad
approved these changes
May 5, 2025
Collaborator
zyxkad
left a comment
zyxkad
left a comment
There was a problem hiding this comment.
Everything else looks good, at least for now :p
Member
Author
|
Yeah I will address the two open reviews of you and then merge |
github-project-automation
Bot
moved this from In Progress
to Done
in Advanced Peripherals
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still needs a description - currently trying to use the new rs2 api to make the RS bridge
Low prio because RS2 isn't released yet