Skip to content

fix: align runtime contracts and outbound auth#349

Merged
liujuanjuan1984 merged 3 commits intomainfrom
issue-346-runtime-contract-hygiene
Mar 27, 2026
Merged

fix: align runtime contracts and outbound auth#349
liujuanjuan1984 merged 3 commits intomainfrom
issue-346-runtime-contract-hygiene

Conversation

@liujuanjuan1984
Copy link
Copy Markdown
Collaborator

概要

  • 收敛 server-side outbound Basic auth 与运行时配置接线
  • 对齐 compatibility / wire contract 与 SDK 实际暴露的 core A2A surface
  • 澄清 /health 的认证语义与公开发现边界
  • 补充最小开源治理文档并规范包元数据

按模块说明

Runtime / Auth

  • 为运行时 Settings 增加 A2A_CLIENT_BASIC_AUTH
  • A2AClientManager 的 server-side outbound client 配置补齐 Basic auth 透传
  • 补充对应配置与 manager 测试

Contracts / Agent Card

  • 将 core JSON-RPC methods 收敛到 SDK 当前 METHOD_TO_MODEL 暴露面
  • 补充 GET /v1/tasks 与 push notification config 相关 REST endpoint 声明
  • 更新 Agent Card 描述与契约测试,避免公开 surface 低报

Docs

  • README 补充 SDK-owned A2A surface 说明
  • guide 补充 A2A_CLIENT_BASIC_AUTH/health 认证说明,以及 SDK-owned JSON-RPC / REST surface 说明

Open Source Hygiene

  • 新增 CODE_OF_CONDUCT.md
  • 新增 SUPPORT.md
  • 规范 pyproject.toml 中的 author metadata

验证

  • ./scripts/doctor.sh
  • 440 tests passed
  • total coverage 91.50%

关联

@liujuanjuan1984
Copy link
Copy Markdown
Collaborator Author

审查结果:

  • 未发现阻塞性问题。本 PR 的代码与文档变动能够覆盖 [Priority: High] [Architecture] 收敛 outbound auth、公开契约、health 文档与开源治理卫生偏差 #346 预期收敛的四类问题:server-side outbound Basic auth、公开 surface 契约、/health 认证说明、开源治理卫生。
  • 实现方式合理:将 CORE_JSONRPC_METHODS 收敛到 SDK METHOD_TO_MODEL 作为单一事实源,比继续手写方法列表更稳健,能减少后续 core surface 再次低报的风险。
  • PR 标题与描述已核对:标题采用英文 commit message 风格,描述按 Runtime / Auth、Contracts / Agent Card、Docs、Open Source Hygiene 分块,且 Closes #346Related #347Related #348 的关系表述准确。
  • 残余风险:当前测试已覆盖 Basic auth 配置接线与契约对齐,但尚未新增一条通过 server-side a2a_call 路径实际发出 Basic Authorization 头的端到端断言;这属于后续可补强项,不构成当前合并阻塞。

@liujuanjuan1984
Copy link
Copy Markdown
Collaborator Author

补充审查结论:上一条评论中提到的残余风险已收敛。当前分支新增了 server-side a2a_call -> A2AClientManager -> A2AClient.send_message 路径的 Basic Authorization 头测试,并已再次通过 ./scripts/doctor.sh(441 tests passed,coverage 91.52%)。

@liujuanjuan1984
Copy link
Copy Markdown
Collaborator Author

补充说明:pyproject.tomlauthors[].name 已恢复为 liujuanjuan1984@Intelligent-Internet。此前将其改为组织名属于对作者标识语义的误判,现已按仓库实际语义修正。

@liujuanjuan1984 liujuanjuan1984 merged commit 826cff1 into main Mar 27, 2026
3 checks passed
@liujuanjuan1984 liujuanjuan1984 deleted the issue-346-runtime-contract-hygiene branch March 27, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Priority: High] [Architecture] 收敛 outbound auth、公开契约、health 文档与开源治理卫生偏差

1 participant