Skip to content

Fix sitting motion and remove spasms#573

Merged
oxkitsune merged 5 commits intomainfrom
gijs/fix-startup
Apr 13, 2025
Merged

Fix sitting motion and remove spasms#573
oxkitsune merged 5 commits intomainfrom
gijs/fix-startup

Conversation

@oxkitsune
Copy link
Copy Markdown
Member

What

  • Robot now correctly maintains its state when starting yggdrasil. E.g. it will keep standing instead of sitting down.
  • The sitting gait of the walking engine no longer makes the robot fall over when starting yggdrasil.
  • The joint current optimizer is now also applied whilst the robot is sitting.
  • The robot no longer spasms when yggdrasil is started.

@oxkitsune oxkitsune added bug Something isn't working enhancement New feature or request cleanup Fixes some doodoo code tested on robot Verified to work on a robot parameter change Simple parameter tweak or settings change labels Apr 12, 2025
@oxkitsune oxkitsune self-assigned this Apr 12, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

yggdrasil/src/motion/walking_engine/mod.rs:154

  • The change from 0.8 to 0.0 for arm stiffness may introduce unintended behavior; please verify that setting arm stiffness to zero is intentional.
ArmJoints::fill(0.0),

yggdrasil/src/kinematics/mod.rs:176

  • The adjustment in foot translation now adds 'ANKLE_TO_SOLE.z', which alters the computed foot position; please confirm that this change correctly reflects the intended physical model.
hip_height + dimensions::ANKLE_TO_SOLE.z

Comment thread yggdrasil/src/motion/walking_engine/gait/sit.rs
Comment thread deploy/config/walking_engine.toml Outdated
Co-authored-by: Harold <37922636+YukumoHunter@users.noreply.github.com>
@oxkitsune oxkitsune merged commit e9bd385 into main Apr 13, 2025
@oxkitsune oxkitsune deleted the gijs/fix-startup branch April 13, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup Fixes some doodoo code enhancement New feature or request parameter change Simple parameter tweak or settings change tested on robot Verified to work on a robot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants