Migrate build system to scikit-build-core#83
Merged
Conversation
Replace the setuptools/manual wheel building pipeline with scikit-build-core and pip-fetched nanobind. This enables proper multi-Python version builds via cibuildwheel (Phase 2) and eliminates the vcpkg dependency. Changes: - New root pyproject.toml with scikit-build-core backend - CMakeLists.txt: removed hardcoded compiler paths, nanobind via find_package, install() directives for extension + DLLs, GTest via FetchContent (guarded behind SKBUILD) - Single version source in pyproject.toml (0.12.0.dev0), read via importlib.metadata in __init__.py - uv config for CUDA-enabled PyTorch from pytorch.org index - Simplified CMakePresets.json for local dev (no vcpkg toolchain) - Moved examples to top-level examples/ directory Removed: - package/ directory (setup.py, build_wheels.py, build_package.bat, docs, pyd_files) - build.bat, vcpkg-configuration.json, CMakePresets templates - external/nanobind submodule (now pip-fetched as build dependency) - install/ directory (modules, docs, stubs, internal_examples)
3 tasks
keithlostracco
added a commit
that referenced
this pull request
May 27, 2026
Replace the setuptools/manual wheel building pipeline with scikit-build-core and pip-fetched nanobind. This enables proper multi-Python version builds via cibuildwheel (Phase 2) and eliminates the vcpkg dependency. Changes: - New root pyproject.toml with scikit-build-core backend - CMakeLists.txt: removed hardcoded compiler paths, nanobind via find_package, install() directives for extension + DLLs, GTest via FetchContent (guarded behind SKBUILD) - Single version source in pyproject.toml (0.12.0.dev0), read via importlib.metadata in __init__.py - uv config for CUDA-enabled PyTorch from pytorch.org index - Simplified CMakePresets.json for local dev (no vcpkg toolchain) - Moved examples to top-level examples/ directory Removed: - package/ directory (setup.py, build_wheels.py, build_package.bat, docs, pyd_files) - build.bat, vcpkg-configuration.json, CMakePresets templates - external/nanobind submodule (now pip-fetched as build dependency) - install/ directory (modules, docs, stubs, internal_examples)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/directoryDev workflow
Test plan
uv sync --extra examplesbuilds from source and installs CUDA torchimport touchpyworks, version shows0.12.0.dev0