Closed
Conversation
The new baseline is OpenSSL 1.1.1 or LibreSSL 2.8.0. I chose the former
because it's the version available in Rocky Linux 8 (and presumably RHEL 8),
which is still under support. The latter is just because it's been released
around the same time.
By doing this, we can drop every preprocessor conditional that depends on
`OPENSSL_VERSION_NUMBER` and almost every one that depends on
`LIBRESSL_VERSION_NUMBER`.
In addition, we can now make the following simplifications:
* Drop support for SSLv2, since neither library supports it anymore.
For backwards compatibility, the protocol name is still allowed in the
config, but does nothing.
* Remove the setting of the `SSL_OP_SINGLE_{EC,}DH_USE` options, since
they're now permanently enabled in both libraries.
* Remove the `OPENSSL_init_ssl` call, which is now unnecessary.
* Remove the manual seeding code, since both libraries now handle seeding
automatically. In LibreSSL, `RAND_load_file` doesn't even do anything.
SpecLad
force-pushed
the
drop-old-openssl
branch
from
2c597c9 to
1130fb1
Compare
Contributor
|
Thanks for the cleaning. I'll have a deeper look at it next week, and integrate it into INN. Note that Solaris 10 and 11.3 still have OpenSSL 1.0.2 but will soon be unsupported Solaris versions (January 2027). |
Contributor
|
Many thanks again for your very careful patch. I see you removed the useless #ifdef checks on constants that are always defined in OpenSSL 1.1.1 and LibreSSL 2.8.0. Patch proof-read. Build tested OK with OpenSSL 1.1.1 and 3.5.0 as well as LibreSSL 2.8.0 and 4.1.0. |
Julien-Elie
added
cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new baseline is OpenSSL 1.1.1 or LibreSSL 2.8.0. I chose the former because it's the version available in Rocky Linux 8 (and presumably RHEL 8), which is still under support. The latter is just because it's been released around the same time.
By doing this, we can drop every preprocessor conditional that depends on
OPENSSL_VERSION_NUMBERand almost every one that depends onLIBRESSL_VERSION_NUMBER.In addition, we can now make the following simplifications:
Drop support for SSLv2, since neither library supports it anymore. For backwards compatibility, the protocol name is still allowed in the config, but does nothing.
Remove the setting of the
SSL_OP_SINGLE_{EC,}DH_USEoptions, since they're now permanently enabled in both libraries.Remove the
OPENSSL_init_sslcall, which is now unnecessary.Remove the manual seeding code, since both libraries now handle seeding automatically. In LibreSSL,
RAND_load_filedoesn't even do anything.This partly implements #321.