Skip to content

Rename blacklist to blocklist#335

Closed
jlduran wants to merge 1 commit intoInterNetNews:mainfrom
jlduran:blocklist
Closed

Rename blacklist to blocklist#335
jlduran wants to merge 1 commit intoInterNetNews:mainfrom
jlduran:blocklist

Conversation

@jlduran
Copy link
Copy Markdown
Contributor

@jlduran jlduran commented Mar 28, 2026

Current versions of NetBSD and FreeBSD are using the new nomenclature.

Current versions of NetBSD and FreeBSD are using the new nomenclature.
@jlduran
Copy link
Copy Markdown
Contributor Author

jlduran commented Mar 30, 2026

@Julien-Elie
Copy link
Copy Markdown
Contributor

Thanks for your patch. I'll merge it this week.
I'll mention you as a contributor and add a news entry about the change (instead of modifying the changelog of an old release).

Noted for the discussion with Kevin Bowling.

I am glad to see this feature is still used and useful.

@Julien-Elie Julien-Elie self-assigned this Mar 30, 2026
@Julien-Elie Julien-Elie added bug Something isn't working C: nnrpd Related to nnrpd P: low Low priority labels Mar 30, 2026
@Julien-Elie Julien-Elie added this to the 2.7.4 milestone Mar 30, 2026
@jlduran jlduran deleted the blocklist branch April 4, 2026 03:13
Julien-Elie pushed a commit that referenced this pull request Apr 4, 2026
Current versions of NetBSD and FreeBSD are using the new nomenclature.

close #335
@kev009
Copy link
Copy Markdown
Contributor

kev009 commented Apr 24, 2026

Hi @Julien-Elie , we are discussing how to land this in FreeBSD ports, it is somewhat split right now because we have a mostly unified build for inn and inn-current, but this difference will require special handling. Do you plan to do a 2.7.4 release soon? If so I will hold off updating inn-current until then so we can use the same logic on both builds.

@Julien-Elie
Copy link
Copy Markdown
Contributor

Hi Kevin, I had not planned a release soon (not many changes since the 2.7.3) but if it is really needed, I can do it for mid June.
Looking at the discussions in FreeBSD, if I understand well, the issue would be to have a tarball with the configure script. Couldn't you exceptionally take the latest 2.7.3 snapshot available at https://downloads.isc.org/isc/inn/snapshots/ for this blocklist move?

Also, as for the problem of double compatibility between blacklist and blocklist, maybe the easiest would be to implement it in m4/blocklist.m4? If AC_CHECK_HEADER([blocklist.h]) fails, then add the logics for blacklist.h. This way, you wouldn't have to care about FreeBSD versions and remembering to remove the check in a further package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working C: nnrpd Related to nnrpd P: low Low priority

Development

Successfully merging this pull request may close these issues.

3 participants