Stream ogg songs from disk#1023
Merged
Interkarma merged 2 commits intoInterkarma:masterfrom Nov 14, 2018
Merged
Conversation
MidnightPrince assembled a kickass soundscape for Daggerfall Unity https://forums.dfworkshop.net/viewtopic.php?f=14&t=1347#p16078 All songs are replaced with OGG music, and there's a noticeable frames drop when songs (re)start. This patch uses Unity audioClip streaming for digital songs.
|
I likey ! |
rossipaolo
reviewed
Nov 12, 2018
| /// Import sound data from modding locations as an audio clip. | ||
| /// </summary> | ||
| private static bool TryImportAudioClip(string name, string extension, out AudioClip audioClip) | ||
| private static bool TryImportAudioClip(string name, string extension, out AudioClip audioClip, bool streaming = false) |
Collaborator
There was a problem hiding this comment.
I'm ok with this. Just a small note: the convention is to place the out parameter in the last position. I would prefer if you move streaming before it and just pass true and false respectively.
Collaborator
Author
There was a problem hiding this comment.
Done. Somehow I was expecting to have more places to update...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MidnightPrince assembled a kickass soundscape for Daggerfall Unity
https://forums.dfworkshop.net/viewtopic.php?f=14&t=1347#p16078
All songs are replaced with OGG music, and there's a noticeable frames drop when songs (re)start.
This patch uses Unity audioClip streaming for digital songs.