Weaken shadows under scattered light#1295
Merged
Interkarma merged 2 commits intoMay 17, 2019
Merged
Conversation
added 2 commits
May 12, 2019 08:56
When light is scattered, there should be less hard shadows (only ambient occlusion shadows); This is most obvious during heavy fog. So I modified the shadows to be - slightly lighter during overcast weathers; - very light during snowing weather; - almost inexistant during fog.
petchema
commented
May 12, 2019
| shadowStrength = OvercastShadowStrength; | ||
| } | ||
|
|
||
| shadowStrength *= Mathf.Exp(-50f * currentOutdoorFogSettings.density); |
Collaborator
Author
There was a problem hiding this comment.
I could have added shadowStrength to FogSettings, but that would have broken the compatibility with Enhanced Sky...
So I used a formula instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When light is scattered, there should be less hard shadows (only ambient occlusion shadows); This is most obvious during heavy fog.
So I modified the shadows to be