Speedchanger refinements#1667
Merged
Interkarma merged 9 commits intoInterkarma:masterfrom Feb 2, 2020
Merged
Conversation
added 9 commits
January 15, 2020 23:32
If jumping while running, keep forward momentum when touching ground. You can only switch between running and non-running while grounded. Interestingly, while hopping around, switch only happen on 2nd touch to the ground, not sure why.
Speed is determined by both world conditions and player's input. While it's only required during FixedUpdate() for modifying movement(*), player's input can change with each Update() so that input must be recorded separately. *. Except in LevitateMotor, that can adjust movement with each frame. If we can, we could update speed with each Update() too.
Should the horse be clever enough to not neigh so loudly when you're trying to sneak?
Mostly reverting 067fb0f
It was too quiet, specially with mods like DREAM. Volume difference should be noticeable (helping convey you're sneaking), but footsteps should still be audible, as much as possible.
Owner
|
Works well and no problems found. Thank you. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIx for #1588, and then some (like lowering player's noise volume when sneaking).
Note:
playerMotor.speed is determined by both world conditions and player's input. While it's only required during FixedUpdate() for modifying movement(*), player's input can change with each Update() so that input must be recorded separately.
*. Except in LevitateMotor, that can adjust movement with each frame. If we care, we could update speed with each Update() too.