Allow long unused textures to be unloaded#1671
Merged
Interkarma merged 1 commit intoInterkarma:masterfrom Feb 2, 2020
Merged
Conversation
rossipaolo
added
the
enhancement
petchema
reviewed
Jan 21, 2020
petchema
reviewed
Jan 21, 2020
| float threshold = AssetCacheThreshold * 60; | ||
| foreach (var item in materialDict.Where(x => time - x.Value.timeStamp > threshold).ToList()) | ||
| materialDict.Remove(item.Key); | ||
| } |
Collaborator
There was a problem hiding this comment.
Can you add some log, say "x materials expired"?
Collaborator
Author
There was a problem hiding this comment.
I don't think this would be valuable information, the log is already a bit "spammy" at times...
petchema
reviewed
Jan 21, 2020
Added experimental setting "AssetCacheThreshold". If different than zero, this is the time in minutes from last access for which a texture can be stored in cache. During fast travels textures that exceed this value are removed to allow Unity to unload them if unused.
rossipaolo
force-pushed
the
texture-cache
branch
from
d87b7ae to
3627a5f
Compare
Owner
|
I'm happy with this. Thank you. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added experimental setting "AssetCacheThreshold". If different than zero, this is the time in minutes from last access for which a texture can be stored in cache. During fast travels textures that exceed this value are removed to allow Unity to unload them if unused.