Skip to content

Support custom implementations of mobile units#1763

Merged
Interkarma merged 2 commits into
Interkarma:masterfrom
rossipaolo:mobile-unit
Mar 17, 2021
Merged

Support custom implementations of mobile units#1763
Interkarma merged 2 commits into
Interkarma:masterfrom
rossipaolo:mobile-unit

Conversation

@rossipaolo
Copy link
Copy Markdown
Collaborator

@rossipaolo rossipaolo commented Mar 24, 2020

The same as #1598, this time for enemies.

ExampleMobileUnit.zip

@rossipaolo rossipaolo added the mod system An issue or a request related to mods development. label Mar 24, 2020
@rossipaolo rossipaolo self-assigned this Mar 24, 2020
Comment thread Assets/Scripts/Internal/DaggerfallMobileBillboard.cs Outdated
Comment thread Assets/Scripts/Internal/DaggerfallMobileBillboard.cs Outdated
@rossipaolo rossipaolo requested review from Interkarma and ajrb March 24, 2020 18:28
@ajrb
Copy link
Copy Markdown
Collaborator

ajrb commented Mar 24, 2020

Generally seems fine, although this is not code I am familiar with so I may well miss something.

My understanding is that this allows the visuals for enemies to be changed into models, is that correct? Pretty sure the sprites can already be replaced.

@rossipaolo
Copy link
Copy Markdown
Collaborator Author

Yes, it allows to provide a custom implementation of enemy graphics. For example MasonFace is currently trying to use an opensource framework for npcs; i think he plans to do monsters next.

@rossipaolo
Copy link
Copy Markdown
Collaborator Author

df_enemy

@Interkarma
Copy link
Copy Markdown
Owner

I love where this is going. Thank you for help with review. I'll take a look at this one more closely when I can, and once conflicts resolved.

@Interkarma
Copy link
Copy Markdown
Owner

Hey @TheLacus! :) My apologies for losing track of this PR. I see you're still working on this one. Just ping me when out of draft and ready for review. I don't have any issues with how you're implementing this so far. I'll do my best to test and help find any issues once you're happy with it. Then we can move into master finally. :)

@rossipaolo
Copy link
Copy Markdown
Collaborator Author

Thank you! jefetienne also proposed to help testing, so hopefully we'll get this feature available to mod authors soon.

@rossipaolo rossipaolo force-pushed the mobile-unit branch 7 times, most recently from fee692a to 441e08e Compare January 1, 2021 18:09
@rossipaolo rossipaolo changed the title Support custom implementations of mobile units (WIP) Support custom implementations of mobile units Jan 23, 2021
@rossipaolo
Copy link
Copy Markdown
Collaborator Author

I uploaded a simple mod that can help with testing. My understanding is that combat behaviour (DoMeleeDamage and ShootArrow) is strictly linked with billboard animation frames, so mod authors need to reimplement both asset handling and combat for specific enemies. I'm not sure if we can make it a bit easier to manage, but in any case i think is something that can be revised at a later time.

@rossipaolo rossipaolo marked this pull request as ready for review January 23, 2021 17:08
@Interkarma
Copy link
Copy Markdown
Owner

Thanks for all your hard work on this one @rossipaolo. I'm happy with all your changes and haven't been able to find any issues in base game. Really looking forward to watching this one evolve as modders start using this.

@Interkarma Interkarma merged commit aa41ccc into Interkarma:master Mar 17, 2021
@rossipaolo rossipaolo deleted the mobile-unit branch April 28, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod system An issue or a request related to mods development.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants