Fix damage values#355
Merged
Interkarma merged 1 commit intoInterkarma:masterfrom Jun 26, 2017
Merged
Conversation
Owner
|
I appreciate all your work on this, thank you :) |
Contributor
Author
|
No problem. It's interesting finding this stuff that doesn't work as described. Edit: Wrote a longish post about stuff I found that didn't work as expected. I'll note them in the source as I submit PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some fixes to damage values from the player's weapon hits.
It turns out there were a number of inaccurate things in the information Daggerfall gives about damage values, which were throwing me off until I figured them out. One is that the diagonal slash down to the right is actually a weaker attack than the horizontal attacks. The other diagonal attack is stronger, and the manual groups them together as both being stronger.
Another was that the strength damage modifier is different from what classic shows in the character sheet. It's actually (STR - 50) / 5, roughly twice the value that classic shows, in either negative or positive direction.
And then another was that the damage display for weapons with material modifiers (those other than steel and silver) is also incorrect! The material modifier to damage is half of what is shown, in both positive and negative direction.
This is backed up by a whole lot of testing and I'm pretty sure about these.