Skip to content

Conversation

@waywardmonkeys
Copy link
Contributor

No description provided.

Copy link
Collaborator

@nbriggs nbriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK -- the only hesitation is because the original makefile-init.* files (which don't include the makefile-init.386) all did NOT have -DNEW_STORAGE. Looking in the Lisp side of things for the Interface Page we find in LLPARAMS:

             (EMUBUFLENGTH WORD)  (* ; "Number of words of said space")
       (* ;;  "The following 2 are available if NEW_STOARGE is specified in C")
             (ProcessSize WORD)  (* ; "Process size for which can be use as LISP space")
             (StorageFullState WORD) (* ; "Save last storage state")
             (ISFMAP WORD)

So we need to leave tracks so people reading the Lisp side know that those two words are now always there. Oddly, when I looked in the LLBFS (low level basic file system) code, where it would use the "sysdisk" field that is being replaced by "storagefullstate", I found that I was the last person who edited \INITBFS, 16 Feb 1987 10:26 AM.

@waywardmonkeys
Copy link
Contributor Author

How should we do this on the Lisp side?

@nbriggs
Copy link
Collaborator

nbriggs commented Dec 28, 2020

We can't remake the LLPARAMS file at the moment, so perhaps we should leave a comment in the version.h saying that -DNEW_STORAGE was removed as it is now always true and that that is relevant to the comments in LLPARAMS

This removes the code paths for the pre-NEW_STORAGE code.
The code no longer refers to `NEW_STORAGE`, so we can remove
this from the build system.
@waywardmonkeys
Copy link
Contributor Author

I've added a comment in inc/version.h, rebased against current master, and force-pushed.

Does the comment in inc/version.h look okay to you?

Copy link
Collaborator

@nbriggs nbriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nbriggs nbriggs merged commit 01926fc into Interlisp:master Dec 28, 2020
@waywardmonkeys waywardmonkeys deleted the always-do-NEW_STORAGE branch December 29, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants