Skip to content

VM config controlled by RELEASE version #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2020
Merged

VM config controlled by RELEASE version #136

merged 1 commit into from
Dec 30, 2020

Conversation

@waywardmonkeys
Copy link
Contributor

@waywardmonkeys waywardmonkeys commented Dec 28, 2020

This is a placeholder PR that requires #135 to be merged first. Then I'll update this one as needed.

nbriggs
nbriggs reviewed Dec 28, 2020
View reviewed changes
Copy link
Collaborator

@nbriggs nbriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BIGVM and NEWCDRCODING are candidates for similar cleanup. They are both defined in version.h with respect to particular RELEASE values (though your commit comment says VERSION)

@waywardmonkeys
Copy link
Contributor Author

waywardmonkeys commented Dec 29, 2020

I was going to do those separately, but I will combine them into a single PR (this one).

@waywardmonkeys
Control VM config via RELEASE.
3f94f9b 
When `RELEASE` is set, then `inc/version.h` configures some
defines appropriately, including `BIGATOMS`, `BIGVM`, and
`NEWCDRCODING`. There's no need to manage it directly on
the compiler command line.
@waywardmonkeys waywardmonkeys force-pushed the BIGATOMS-controlled-by-VERSION branch from 601ed1f to 3f94f9b Compare December 29, 2020 02:41
@waywardmonkeys
Copy link
Contributor Author

waywardmonkeys commented Dec 29, 2020

Updated and pushed. This just shows though that a bunch of the DOS-related files in bin are ancient relics and need to be removed. I wish we knew why half those files even existed.

@waywardmonkeys waywardmonkeys marked this pull request as ready for review December 29, 2020 02:43
@waywardmonkeys waywardmonkeys changed the title Bigatoms controlled by version VM config controlled by RELEASE version Dec 29, 2020
@nbriggs
Copy link
Collaborator

nbriggs commented Dec 29, 2020

Some should certainly go, next pass, although they're not currently doing any harm.
makefile-dos and makefile.dos differ in whether they refer to /src or /dossrc and /inc vs /dosinc, and one of them had the Linear Programming solver (an external package) built in (-DLPSOLVE)

mkfile.i looks like what you get if you run mkfile.c through the C preprocessor with a few -Dxxx values, and mkfile is a further processed version, i'd guess. It looks as though Jarl Nilsson was reworking the build system. I guess he used cpp rather than m4 because it got run on DOS boxes :-( Glad I didn't have anything to do with it.

nbriggs
nbriggs approved these changes Dec 30, 2020
View reviewed changes
Copy link
Collaborator

@nbriggs nbriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbriggs nbriggs merged commit 7a74d6e into Interlisp:master Dec 30, 2020
@waywardmonkeys waywardmonkeys deleted the BIGATOMS-controlled-by-VERSION branch December 30, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbriggs nbriggs nbriggs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@waywardmonkeys @nbriggs