ARG NOT LINEDESCRIPTOR in TEDIT

[masinter]

a full backtrace

BT.TXT

[rmkaplan]

Where were you clicking?

…

On Mar 22, 2024, at 5:00 PM, Larry Masinter ***@***.***> wrote: image.png (view on web) <https://github.com/Interlisp/medley/assets/1116587/d1a8b54c-7521-4cf6-ae3a-e0c266aaaf2f> a full backtrace BT.TXT <https://github.com/Interlisp/medley/files/14729419/BT.TXT> — Reply to this email directly, view it on GitHub <#1609>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJLVPC7G3LWSDSJYWHDYZTAYRAVCNFSM6AAAAABFEEV6QGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYDGNJTGQYTMNI>. You are receiving this because you are subscribed to this thread.

[masinter]

i had some text i had selected and I was trying to delete it. But I forgot that delete-forward has been added and I was looking for "delete selection".  In fact, in most systems, the DEL key is "delete forward" only if there is no selection. If there's a selection, the DEL key should delete the selection first. Only if there is no selection do delete forward.
I might have clicked on the selected text, not sure.
On Fri, Mar 22, 2024 at 5:41 PM rmkaplan notifications@github.com wrote:
Where were you clicking?

On Mar 22, 2024, at 5:00 PM, Larry Masinter @.***> wrote:

image.png (view on web) https://github.com/Interlisp/medley/assets/1116587/d1a8b54c-7521-4cf6-ae3a-e0c266aaaf2f
a full backtrace

BT.TXT https://github.com/Interlisp/medley/files/14729419/BT.TXT
—
Reply to this email directly, view it on GitHub #1609, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSTUJLVPC7G3LWSDSJYWHDYZTAYRAVCNFSM6AAAAABFEEV6QGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYDGNJTGQYTMNI.
You are receiving this because you are subscribed to this thread.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread. Message ID: Interlisp/medley/issues/1609/2016234030@github.com

--
https://larrymasinter.net/  https://interlisp.org/

[nbriggs]

In fact, in most systems, the DEL key is "delete forward" only if there is no selection. If there's a selection, the DEL key should delete the selection first. Only if there is no selection do delete forward.

On a Mac, in the text editor and in a terminal window, the DEL key is delete selection then delete backwards - while fn-DEL is delete selection then delete forwards.

[rmkaplan]

Textedit on the mac, if there is a selection, DELETE and DEL both do the same thing: delete the selection. No other character (before or after the selection) is affected, with either key. If no selection, DELETE deletes the characte before the caret, DEL deletes the following character. Is that the target behavior?

…

On Mar 22, 2024, at 6:27 PM, Nick Briggs ***@***.***> wrote: In fact, in most systems, the DEL key is "delete forward" only if there is no selection. If there's a selection, the DEL key should delete the selection first. Only if there is no selection do delete forward. On a Mac, in the text editor and in a terminal window, the DEL key is delete selection then delete backwards - while fn-DEL is delete selection then delete forwards. — Reply to this email directly, view it on GitHub <#1609 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJK6FWTI4ODVNIVSWCTYZTK7RAVCNFSM6AAAAABFEEV6QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGI3TGOBYG4>. You are receiving this because you commented.

[rmkaplan]

The BT looks like its decoding a mouse click, not executing an action from a key stroke. It looks like the click is at Y=456 from the bottom of the window, and at X= 69 from the left edge of the window. And then it looks like either there is no line at 456, or there is a line starting at character 209 and going for 212 characters, hard to say. Any idea how high the window might have been? In a situation like this, if you can do a sysout in the break and send it, that would make it easier.

…

On Mar 22, 2024, at 6:22 PM, Larry Masinter ***@***.***> wrote: i had some text i had selected and I was trying to delete it. But I forgot that delete-forward has been added and I was looking for "delete selection". In fact, in most systems, the DEL key is "delete forward" only if there is no selection. If there's a selection, the DEL key should delete the selection first. Only if there is no selection do delete forward. I might have clicked on the selected text, not sure. On Fri, Mar 22, 2024 at 5:41 PM rmkaplan ***@***.*** ***@***.***> wrote: Where were you clicking? On Mar 22, 2024, at 5:00 PM, Larry Masinter @.***> wrote: image.png (view on web) https://github.com/Interlisp/medley/assets/1116587/d1a8b54c-7521-4cf6-ae3a-e0c266aaaf2f a full backtrace BT.TXT https://github.com/Interlisp/medley/files/14729419/BT.TXT — Reply to this email directly, view it on GitHub #1609 <#1609>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSTUJLVPC7G3LWSDSJYWHDYZTAYRAVCNFSM6AAAAABFEEV6QGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYDGNJTGQYTMNI. You are receiving this because you are subscribed to this thread. — Reply to this email directly, view it on GitHub <#1609 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIQTK6W2GWGCDYDZNG2Q3TYZTFTNAVCNFSM6AAAAABFEEV6QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGIZTIMBTGA>. You are receiving this because you authored the thread. Message ID: ***@***.*** ***@***.***> -- https://larrymasinter.net/  https://interlisp.org/ <https://larrymasinter.net/%C2%A0%C2%A0https://interlisp.org/> — Reply to this email directly, view it on GitHub <#1609 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJOHP2XISHE3QZZEL2TYZTKM5AVCNFSM6AAAAABFEEV6QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGI3DIMRVHE>. You are receiving this because you commented.

[rmkaplan]

BTW, I don’t think that Tedit ever deleted the selection when the DELETE key was pressed, it seemed always to ignore the selection and just delete the preceding character. Easy to change.

…

On Mar 22, 2024, at 7:27 PM, Ron Kaplan ***@***.***> wrote: Textedit on the mac, if there is a selection, DELETE and DEL both do the same thing: delete the selection. No other character (before or after the selection) is affected, with either key. If no selection, DELETE deletes the characte before the caret, DEL deletes the following character. Is that the target behavior? > On Mar 22, 2024, at 6:27 PM, Nick Briggs ***@***.***> wrote: > > > In fact, in most systems, the DEL key is "delete forward" only if there is no selection. If there's a selection, the DEL key should delete the selection first. Only if there is no selection do delete forward. > > On a Mac, in the text editor and in a terminal window, the DEL key is delete selection then delete backwards - while fn-DEL is delete selection then delete forwards. > > — > Reply to this email directly, view it on GitHub <#1609 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJK6FWTI4ODVNIVSWCTYZTK7RAVCNFSM6AAAAABFEEV6QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGI3TGOBYG4>. > You are receiving this because you commented. >

[masinter]

https://drive.google.com/file/d/108fC06XNN11NAXAn_5kE2b23sMRjm-3B/view?usp=sharing

I made a sysout and copied it to Google Drive.

[nbriggs]

BTW, I don’t think that Tedit ever deleted the selection when the DELETE key was pressed, it seemed always to ignore the selection and just delete the preceding character.

Yeah, I always found that unintuitive. I selected something for deletion (it's even blue-pending-delete) but then DEL doesn't delete it when typing any other (printing?) character would replace the selection.

[nbriggs]

If no selection, DELETE deletes the characte before the caret, DEL deletes the following character.
Is that the target behavior?

That would be my choice - but I'm not the only one involved.

[rmkaplan]

I think that’s the way the Mac Textedit works. The code for the 2 delete keys just has to do the bluependingdelete test.

…

On Mar 22, 2024, at 9:06 PM, Nick Briggs ***@***.***> wrote: If no selection, DELETE deletes the characte before the caret, DEL deletes the following character. Is that the target behavior? That would be my choice - but I'm not the only one involved. — Reply to this email directly, view it on GitHub <#1609 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJJ34VYALFHD2VNKOZTYZT5T3AVCNFSM6AAAAABFEEV6QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGMZTOMRTGI>. You are receiving this because you commented.

[rmkaplan]

Got it, thanks. I probably won’t be able to look at it until next week.

…

On Mar 22, 2024, at 8:04 PM, Larry Masinter ***@***.***> wrote: https://drive.google.com/file/d/108fC06XNN11NAXAn_5kE2b23sMRjm-3B/view?usp=sharing I made a sysout and copied it to Google Drive. — Reply to this email directly, view it on GitHub <#1609 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJNCHWJEBM56RL522ULYZTWMVAVCNFSM6AAAAABFEEV6QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGMZDEMBUGU>. You are receiving this because you commented.

[rmkaplan]

A little more on this: It seems that the display information got smashed, kind of like something happened to the display lines in the middle of a delete. But the underlying document is intact and a redisplay restores the display to a reasonable configuration. I don’t think I can do much with this now, will have to wait until the next line-descriptor break. And then again, try to save the break sysout, and report as much as possible what exactly preceded the break. It would also help to get the Unicode PR approved and merged, so I can then set up a PR to get master consistent with my current Tedit working environment. I have done the initial renaming of functions to more clearly separate the external interface functions from the internals (systematically with \TEDIT.xxx). This is also in preparation for the eventual move to a Tedit package (starting with a global substitution of TEDIT:: for \TEDIT.). I don’t want to try to track incremental changes in both environments.

…

On Mar 22, 2024, at 11:53 PM, Ron Kaplan ***@***.***> wrote: Got it, thanks. I probably won’t be able to look at it until next week. > On Mar 22, 2024, at 8:04 PM, Larry Masinter ***@***.***> wrote: > > > https://drive.google.com/file/d/108fC06XNN11NAXAn_5kE2b23sMRjm-3B/view?usp=sharing > > I made a sysout and copied it to Google Drive. > > — > Reply to this email directly, view it on GitHub <#1609 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJNCHWJEBM56RL522ULYZTWMVAVCNFSM6AAAAABFEEV6QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGMZDEMBUGU>. > You are receiving this because you commented. >

[nbriggs]

@rmkaplan - by "the Unicode PR", do you mean #1528 unicode on demand? It's currently in a conflicting state with master following the changes that got merged with TEdit round 4.

[rmkaplan]

I’ll look.

…

On Mar 26, 2024, at 3:43 PM, Nick Briggs ***@***.***> wrote: @rmkaplan <https://github.com/rmkaplan> - by "the Unicode PR", do you mean #1528 <#1528> unicode on demand? It's currently in a conflicting state with master following the changes that got merged with TEdit round 4. — Reply to this email directly, view it on GitHub <#1609 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJMTNW6572M2FJ7PKZDY2H2YHAVCNFSM6AAAAABFEEV6QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRRGU4TEMZUGU>. You are receiving this because you were mentioned.