LLSYMBOL's FILEMAP was also incomplete #1381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update hopefully won't reveal any other problems
masinter
approved these changes
Nov 29, 2023
Member
masinter
left a comment
masinter
left a comment
There was a problem hiding this comment.
isn't it more work to do this one-by-one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update hopefully won't reveal any other problems.
The symptom that a map is incomplete (doesn't include DEFUNs or DEFMACROS) is that WHEREIS says that the item is on the file, but PF can't find it. A general solution would be to fix PF so that it doesn't depend on filemaps (speed maybe not so important nowadays), but until then, file by file as they are encountered.